Load notice text from NOTICE file #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it more stand out and align with the acknowledgment formatting.
|
Thanks. Let me review tomorrow. |
|
I am rebasing and merging this. Thanks! |
|
There are some issue with loading the NOTICE file text when scancode is built as a wheel, as the root directory is not the same as the project directory. I will have to amend this somehow. |
|
Sorry for that. I wasn't even aware that ScanCode might be built as a wheel. |
pombredanne
added a commit
that referenced
this pull request
Feb 17, 2017
* this is a first step towards #381 * code and tests have been split from the scancode module * Also restore the ability to run ScanCode as a library by vendoring the NOTICE file. This was a regression introduced in #424 and tracked as #468 Signed-off-by: Philippe Ombredanne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.